This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: rework http-api tests to use ipfsd-ctl #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Merged
|
windows tests are failing because of lack of graceful stop - ipfs/js-ipfsd-ctl#205 |
daviddias
suggested changes
Feb 26, 2018
There was a problem hiding this comment.
@dryajov good initiative 👍
Given that now these tests effectively use the ipfs-api, they are not really "extra" anymore as in "we don't use .inject to try to simulate requests". They should be merged to the ipfs-api suite of tests (aka spec https://github.com/ipfs/js-ipfs/tree/master/test/http-api/spec).
You will probably find a lot of duplicates, meaning that we can trim it down :)
Read the changes wrong. Don't mind me :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the http-api tests and reworked those that made sense