Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$a_{ij}$ matrix procedure #85

Closed
fedebenelli opened this issue Jul 4, 2024 · 1 comment
Closed

$a_{ij}$ matrix procedure #85

fedebenelli opened this issue Jul 4, 2024 · 1 comment
Assignees

Comments

@fedebenelli
Copy link
Member

Right now the $a_{ij}$ matrix is a procedure pointer of QMR with the the interface aij(ai, daidt, daidt2, aij, daijdt, daijdt2). This make it limited to $T$ independent combining rule, the interface should be updated or maybe change the logic to use other kind of inheritance.

    type, extends(CubicMixRule) :: QMR
        real(pr), allocatable :: k(:, :) 
            !! Attractive Binary Interatction parameter matrix
        real(pr), allocatable :: l(:, :) 
            !! Repulsive Binary Interatction parameter matrix
        procedure(get_aij), pointer :: aij => null()
            !! Procedure to calculate \(a_{ij}\) matrix. Can be overloaded
            !! by any method that respets the interface [[get_aij(interface)]].
    contains
        procedure :: Dmix !! Attractive parameter mixing rule
        procedure :: Bmix !! Repulsive parameter mixing rule
        procedure :: D1mix => D1mix_constant
    end type QMR
@fedebenelli fedebenelli self-assigned this Jul 4, 2024
@fedebenelli fedebenelli mentioned this issue Jul 25, 2024
@fedebenelli
Copy link
Member Author

This should be already fixed on the dev branch. We'll see if the issue closes once this reaches main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant