Skip to content

Commit

Permalink
Fix regex for publishing v2 image (#5988)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Release attempt did not publish v2 image 
```
[[ v2.0.0-rc1 =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]
+ echo 'skipping docker images upload, because not on tagged release or main branch'
```

## Description of the changes
- Fix the regex to include -rc suffix

## How was this change tested?
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
  • Loading branch information
yurishkuro committed Sep 15, 2024
1 parent e047f20 commit 0824fc2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/build-upload-a-docker-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ else
echo "::endgroup::"

# Only push multi-arch images to dockerhub/quay.io for main branch or for release tags vM.N.P{-rcX}
if [[ "$BRANCH" == "main" || $BRANCH =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
if [[ "$BRANCH" == "main" || $BRANCH =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$ ]]; then
echo "will build docker images and upload to dockerhub/quay.io, BRANCH=$BRANCH"
bash scripts/docker-login.sh
PUSHTAG="type=image,push=true"
Expand Down

0 comments on commit 0824fc2

Please sign in to comment.