testifylint: enable go-require #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5983 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 348 348
Lines 16559 16559
=======================================
Hits 16027 16027
Misses 343 343
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
a866dd6
to
8b128cf
Compare
yurishkuro
reviewed
Sep 15, 2024
pkg/es/client/index_client_test.go
Outdated
| @@ -385,7 +385,7 @@ func TestClientCreateAliases(t *testing.T) { | |||
| assert.Equal(t, http.MethodPost, req.Method) | |||
| assert.Equal(t, "Basic foobar", req.Header.Get("Authorization")) | |||
| body, err := io.ReadAll(req.Body) | |||
| require.NoError(t, err) | |||
| assert.NoError(t, err) | |||
There was a problem hiding this comment.
Maybe this should be used as if condition before using body in the next line
| @@ -501,7 +501,7 @@ func TestGetErrorRatesZero(t *testing.T) { | |||
| defer r.Body.Close() | |||
|
|
|||
| u, err := url.Parse("http://" + r.Host + r.RequestURI + "?" + string(body)) | |||
| require.NoError(t, err) | |||
| assert.NoError(t, err) | |||
plugin/storage/es/factory_test.go
Outdated
| @@ -354,10 +354,10 @@ func testPasswordFromFile(t *testing.T, f *Factory, getClient func() es.Client, | |||
| t.Logf("request to fake ES server: %v", r) | |||
| // epecting header in the form Authorization:[Basic OmZpcnN0IHBhc3N3b3Jk] | |||
| h := strings.Split(r.Header.Get("Authorization"), " ") | |||
| require.Len(t, h, 2) | |||
| require.Equal(t, "Basic", h[0]) | |||
| assert.Len(t, h, 2) | |||
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
8b128cf
to
e515315
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/go-require
branch
from
e515315
to
6425bfd
Compare
yurishkuro
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test