Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README typos for adaptive sampling #6000

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

greut
Copy link
Contributor

@greut greut commented Sep 18, 2024

Which problem is this PR solving?

  • typos spotted while reading the latest release changelog.

Description of the changes

  • two small typos.

How was this change tested?

  • running typos-cli locally.

Checklist

Signed-off-by: Yoan Blanc <yoan.blanc@chuv.ch>
@greut
Copy link
Contributor Author

greut commented Sep 18, 2024

wow, I got lucky with that PR number. 🍀

@yurishkuro yurishkuro merged commit 8eebb99 into jaegertracing:main Sep 18, 2024
38 of 41 checks passed
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (b7e8884) to head (2c4547b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6000      +/-   ##
==========================================
+ Coverage   96.79%   96.81%   +0.01%     
==========================================
  Files         348      348              
  Lines       16559    16559              
==========================================
+ Hits        16029    16031       +2     
+ Misses        342      341       -1     
+ Partials      188      187       -1     
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.04% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.82% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (-0.02%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants