Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting rules #731

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Formatting rules #731

merged 6 commits into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. Introdude formatter and impsort; make sure CI checks formatting

    @manovotn
    manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6778143 View commit details
    Browse the repository at this point in the history

  2. Apply formatting rules to the codebase

    @manovotn
    manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    43c652c View commit details
    Browse the repository at this point in the history

  3. Break lines for readability in example 

    Break the lines in the InjectionTargetFactory example more
intelligently.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
    @Azquelt @manovotn
    Azquelt authored and manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    af5fb4e View commit details
    Browse the repository at this point in the history

  4. Fix example in InterceptionFactory 

    Correct the constructor name in the example, which also causes the
formatter to format it correctly.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
    @Azquelt @manovotn
    Azquelt authored and manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    36b53a5 View commit details
    Browse the repository at this point in the history

  5. Allow closing paren to be on next line 

    Allow (but don't require) the closing parenthesis of a method invocation
to be on the following line.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
    @Azquelt @manovotn
    Azquelt authored and manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    424ecb0 View commit details
    Browse the repository at this point in the history

  6. Manually reflow paragraphs with bad linebreaks 

    The autoformat settings will not join lines together which has resulted
in some cases where the line lengths are very uneven because the
formatter has needed to break a line which was slightly too long.

Reflow these paragraphs manually.

Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
    @Azquelt @manovotn
    Azquelt authored and manovotn committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c867b21 View commit details
    Browse the repository at this point in the history