Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid IE9 activeElement of death #48

Merged
merged 1 commit into from
Nov 7, 2013

Conversation

kristerkari
Copy link

I was testing this polyfill on IE9 and noticed that IE was throwing "SCRIPT16389: Unspecified error". This only happened when I used an iframe to load the page that had the polyfill in use.

Turns out that the error gets thrown if document.activeElement is asked inside an iframe while the page is loading. jQuery already fixed this, so I use the same fix for placeholders.js and after that the page started working normally.

More info:
http://bugs.jquery.com/ticket/13393
jquery/jquery@85fc587

@jamesallardice
Copy link
Owner

Good find! Thanks. Did you notice that your commit is not associated with your GitHub account? If you want to be credited in the contributors page of the repo you'll have to set your git username/email to match your GitHub account (with git config), amend the commit and then force push.

Let me know if you don't care and I'll go ahead and merge as it is. Thanks again.

@kristerkari
Copy link
Author

@jamesallardice You can just go ahead and merge it. :)

jamesallardice pushed a commit that referenced this pull request Nov 7, 2013
Avoid IE9 activeElement of death
@jamesallardice jamesallardice merged commit 096cbf6 into jamesallardice:master Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants