Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mac Legacy from Qt 5.9.9 to 5.15.2 #3235

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

softins
Copy link
Member

@softins softins commented Feb 15, 2024

Short description of changes

Updates the CI build process and makefiles for Mac Legacy to use Qt 5.15.2 instead of 5.9.9. This allows other things also to be improved separately, as described in #3234

CHANGELOG: Build: Update Mac Legacy build to use Qt 5.15.2, now compatible with MacOS 10.13 (High Sierra) or newer.

Context: Fixes an issue?

Fixes #3234

Does this change need documentation? What needs to be documented and how?

We would need to document in the release notes and any download page that the minimum supported version of MacOS for the Legacy build would be 10.13 (High Sierra)

Status of this Pull Request

Working, but awaiting agreement on using Qt 5.15.2.

What is missing until this pull request can be merged?

Just agreement on using Qt 5.15.2

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins self-assigned this Feb 15, 2024
@softins softins force-pushed the mac-legacy-update branch 2 times, most recently from 9d28a8f to cdd6697 Compare March 2, 2024 16:11
@softins softins changed the title Update Mac Legacy from Qt 5.9.9 to 5.15.2 Update Mac Legacy from Qt 5.9.9 to 5.12.12 Mar 2, 2024
@softins softins force-pushed the mac-legacy-update branch 2 times, most recently from 86acc45 to dfbfd75 Compare March 6, 2024 15:43
@softins softins added this to the Release 3.11.0 milestone Mar 28, 2024
@softins
Copy link
Member Author

softins commented Apr 15, 2024

Reverted to using Qt 5.15.2, as per #3234 (comment)

@softins softins changed the title Update Mac Legacy from Qt 5.9.9 to 5.12.12 Update Mac Legacy from Qt 5.9.9 to 5.15.2 Apr 15, 2024
@softins softins marked this pull request as ready for review April 15, 2024 11:29
@softins
Copy link
Member Author

softins commented Jun 6, 2024

I would like to progress this now, because I plan to submit a working PR to replace #2393, and that will be dependent on this one having been merged.

@softins softins requested review from pljones and ann0see June 6, 2024 22:03
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know that I have mixed feelings about this but you can argue that people on those devices should have upgraded years ago.
Going to approve it. But yes, this needs to be explained in the release notes.

@ann0see
Copy link
Member

ann0see commented Jun 7, 2024

We no longer officially link legacy directly on the website anyway as we didn't test it for the last release. So people know it's encouraged not to use it.

Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because it builds clean. I've no way to test it.

@softins
Copy link
Member Author

softins commented Jun 7, 2024

Great, I'll do a final smoke test of the artifact and then merge.

@softins softins merged commit db0724f into jamulussoftware:main Jun 7, 2024
12 checks passed
@softins softins deleted the mac-legacy-update branch June 7, 2024 21:11
@pljones pljones added the dependencies Pull requests that update a dependency file label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update Qt version for Mac Legacy build
3 participants