--ctrlmidich improved documentation #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
from
4fe14d3
to
a71fad6
Compare
5 tasks
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
from
a71fad6
to
d6fbe39
Compare
gilgongo
reviewed
Oct 6, 2024
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
from
d6fbe39
to
3f90839
Compare
ann0see
reviewed
Oct 8, 2024
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
2 times, most recently
from
c0c64d5
to
843b811
Compare
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
from
843b811
to
60a88a5
Compare
gilgongo
approved these changes
Oct 13, 2024
ann0see
approved these changes
Oct 13, 2024
pljones
force-pushed
the
ctrlmidich-improved-doc
branch
from
60a88a5
to
61b3008
Compare
|
Spotted another couple of places I'd said "0 is default" (when it's not -- feature disabled is default). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
jamulussoftware/jamulus#3394 adds a new feature to the
--ctrlmidichoption to allow binding a MIDI CC number explicitly to the participant's "own" channel on the server, regardless of the assigned channel number.This required some changes to the documentation to explain how it worked. I took the opportunity to clarify (hopefully) the detailed information in Tips & Tricks.
Context: Fixes an issue? Related issues
See jamulussoftware/jamulus#3394
Status of this Pull Request
Looks okay locally.
What is missing until this pull request can be merged?
Needs reviewing and shouldn't be merged until after jamulussoftware/jamulus#3394
Does this need translation?
YES
Checklist