Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DRF 3.14 Support #623

Merged
merged 4 commits into from
Apr 9, 2023
Merged

Add DRF 3.14 Support #623

merged 4 commits into from
Apr 9, 2023

Conversation

Andrew-Chen-Wang
Copy link
Member

fixes #622

2ykwang
2ykwang approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@2ykwang 2ykwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jerr0328
Copy link
Contributor

I think tox.ini also needs to be updated to define the new DRF version + constraints

@ahzamm ahzamm mentioned this pull request Oct 25, 2022
Open
@2ykwang
Copy link
Member

2ykwang commented Feb 5, 2023

@Andrew-Chen-Wang How about removing the Django main from the test matrix?

@Andrew-Chen-Wang
Copy link
Member Author

Andrew-Chen-Wang commented Feb 5, 2023 •
edited
Loading

yea that sounds good with me. feel free to edit the branch

@2ykwang
Copy link
Member

2ykwang commented Feb 5, 2023

Can you check the patch? @jerr0328 @Andrew-Chen-Wang

@abczzz13 abczzz13 mentioned this pull request Mar 8, 2023
Merged
@johnthagen
Copy link
Contributor

johnthagen commented Apr 8, 2023 •
edited
Loading

@Andrew-Chen-Wang Anything blocking this PR from being merged (other than a few conflicts)?

@Andrew-Chen-Wang
Copy link
Member Author

thanks for reminder

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit f298efa into master Apr 9, 2023
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the drf-3.14-support branch April 9, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerr0328 jerr0328 jerr0328 approved these changes

@2ykwang 2ykwang 2ykwang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test with DRF 3.14
4 participants
@Andrew-Chen-Wang @jerr0328 @2ykwang @johnthagen