Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated translations for Persian (fa) language #723

Merged

Conversation

mahdirahimi1999
Copy link
Member

@mahdirahimi1999 mahdirahimi1999 commented Jul 3, 2023

Descriptions

This pull request updates the django.po file for the fa (Persian) language in Django REST Framework simplejwt. The update includes new translations for several strings that were previously untranslated or incomplete.

In addition, this pull request fixes several errors and inconsistencies in the existing translations, ensuring that the translations are accurate and consistent with the terminology used in the REST Framework simplejwt codebase.

These changes improve the usability and accessibility of the REST Framework simplejwt for Persian-speaking developers and users.

@mahdirahimi1999
Copy link
Member Author

Please check this PR. @Andrew-Chen-Wang

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Jul 3, 2023

the paths in the po file don't match. They include rest_framework for some reason

@mahdirahimi1999
Copy link
Member Author

the paths in the po file don't match. They include rest_framework for some reason

But I applied these changes last time as well.
#708
Is there a particular problem??

@Andrew-Chen-Wang
Copy link
Member

notice in that PR that the paths don't include rest_framework_simplejwt. The problem is moreso due to sys.path finding (which I can't confirm nor deny, but...) and being more systematic and having everything be ver similar

@mahdirahimi1999
Copy link
Member Author

Please check this PR. @Andrew-Chen-Wang

@mahdirahimi1999
Copy link
Member Author

Please check this PR. @Andrew-Chen-Wang

Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@mahdirahimi1999
Copy link
Member Author

thanks again!

You're welcome.

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 47b7a08 into jazzband:master Jul 6, 2023
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants