Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26583] - Attempt to tweak the injection priorities #124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oleg-nenashev
Copy link
Member

It is an exploratory attempt to fix the resolution order and to make tests provided by @olivergondza working. The fix in #37 was not working with the recent versions of EnvInject (due to #56 by @recena and other changes).

  • - Integrated [WIP][JENKINS-26583] Env-inject suppress variables contributed by extension points #37 with master, polished tests a bit
  • - Prevented EnvInjectPluginAction from overriding variables on late stages, 3 tests fixed
  • - Change the priority of EnvInjectListener to call it first and to let others override the EnvVars
  • - Stop overriding already defined variables in EnvInject listener (likely a breaking change)
  • [ ]
    ....
  • - Make it actually working

@reviewbybees @olivergondza @recena

@ghost
Copy link

ghost commented Sep 28, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant