Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add null alt text to several images #9296

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature/add null alt text to several images #9296

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7c874c4
Merge pull request #1 from jenkinsci/master
JanhviHarwani May 21, 2024
08fc4b7
Added alt attribute to all img tag
janhvi-simform May 21, 2024
4a2c910
Added null as text in alt attribute
janhvi-simform May 21, 2024
8cf6508
Merge pull request #2 from jenkinsci/master
JanhviHarwani May 24, 2024
6d4fa24
Merge branch 'master' of https://github.com/JanhviHarwani/jenkins int…
janhvi-simform May 24, 2024
c7867b2
Merge pull request #3 from jenkinsci/master
JanhviHarwani May 24, 2024
4d8fd42
Resolved all the PR comments
janhvi-simform May 24, 2024
9eafafe
Merge branch 'feature/add-null-text-alt' of https://github.com/Janhvi…
janhvi-simform May 24, 2024
e16257d
Updated alt image messages for dir.jelly, _404_simple.jelly and execu…
janhvi-simform May 24, 2024
1b731b5
Merge branch 'master' into feature/add-null-text-alt
daniel-beck Jun 18, 2024
6275984
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite Jul 27, 2024
b782620
Do not attempt to localize Jenkins welcome page alt text
MarkEWaite Jul 27, 2024
87d4ab4
More clearly describe the participate link
MarkEWaite Jul 27, 2024
904cb3e
Internationalize memory usage monitor graph
MarkEWaite Jul 27, 2024
8d861dd
Use empty alt text when immediately followed by text
MarkEWaite Jul 27, 2024
690501b
Use empty alt text in dropdown documentation example
MarkEWaite Jul 27, 2024
23d56f1
Use empty alt text because nearby text already has the message
MarkEWaite Jul 27, 2024
f110180
Use empty alt text - nearby text already provides details
MarkEWaite Jul 27, 2024
1806b45
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite Jul 28, 2024
42f2883
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ firstPRMergeComment: >

<a href="https://www.jenkins.io/participate/" target="_blank">
<picture>
<img width="600" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is an English language proper noun. It needs to be capitalized.

Suggested change
<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
<img width="600" alt="Jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

Copy link
Member

@daniel-beck daniel-beck May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be localizable.

Suggested change
<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
<img width="600" alt="${%Jenkins welcome page}" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

Additionally I am not sure welcome page adequately describes what this is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we can localize the text in pages that are generated by GitHub Actions.

Copy link
Member

@daniel-beck daniel-beck May 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I managed to comment this on the only file it doesn't apply to 😅 (all your suggestions are not localizable).

</picture>
</a>
2 changes: 1 addition & 1 deletion core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ THE SOFTWARE.
</j:otherwise>
</j:choose>
</div>
<img src="graph?type=${type}&amp;width=500&amp;height=300" />
<img src="graph?type=${type}&amp;width=500&amp;height=300" alt="null" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the memory usage monitor graph, I think that the alt text should say that. The word "null" won't help a disabled user understand what is being shown in the image.

Suggested change
<img src="graph?type=${type}&amp;width=500&amp;height=300" alt="null" />
<img src="graph?type=${type}&amp;width=500&amp;height=300" alt="memory usage monitor graph" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 904cb3e

</l:main-panel>
</l:layout>
</j:jelly>
8 changes: 4 additions & 4 deletions core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ THE SOFTWARE.
${%No files in directory}
<j:if test="${showSymlinkWarning}">
<p>
<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
${%Symlinks are hidden}
</p>
</j:if>
<j:if test="${showTmpDirWarning}">
<p>
<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
${%Tmp directories are hidden}
</p>
</j:if>
Expand Down Expand Up @@ -124,13 +124,13 @@ THE SOFTWARE.
</table>
<j:if test="${showSymlinkWarning}">
<p>
<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="warning image"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
${%Symlinks are hidden}
</p>
</j:if>
<j:if test="${showTmpDirWarning}">
<p>
<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="warning image"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
${%Tmp directories are hidden}
</p>
</j:if>
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/jenkins/model/Jenkins/_404.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ THE SOFTWARE.
<l:header />
<l:main-panel>
<h1 style="text-align: center">
<img src="${imagesURL}/rage.svg" height="179" width="154"/>
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
<span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
</h1>
<div id="error-description" style="text-align: center">
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ THE SOFTWARE.
</head>
<body style="font-family: system-ui, sans-serif">
<h1 style="text-align: center">
<img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle"/>
<img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle" alt="null"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
<span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
</h1>
<div style="text-align: center">
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/jenkins/model/Jenkins/oops.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ THE SOFTWARE.
<l:header />
<l:main-panel>
<h1 style="text-align: center">
<img src="${imagesURL}/rage.svg" height="179" width="154"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="Oops"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorative only. Also, null isn't intended as a literal value, but to represent the explicitly specified empty value (alt="").

Suggested change
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
<img src="${imagesURL}/rage.svg" height="179" width="154" alt=""/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 4d8fd42

</h1>
<div id="error-description">
<h2 style="text-align: center">${%problemHappened}</h2>
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/lib/hudson/executors.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ THE SOFTWARE.
<j:if test="${c.offline}">
<j:choose>
<j:when test="${c.offlineCause!=null and !c.connecting}">
(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}"/> ${%offline})
(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="error image"/> ${%offline})
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
</j:when>
<j:when test="${c.connecting}">
(<l:icon src="symbol-hourglass" class="icon-sm"/>${%launching})
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/lib/layout/dropdowns/custom.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ THE SOFTWARE.

<![CDATA[
<dd:custom>
<img src="jenkins.svg" />
<img src="jenkins.svg" alt="null"/>
MarkEWaite marked this conversation as resolved.
Show resolved Hide resolved
</dd:custom>
]]>
</st:documentation>
Expand Down
Loading