-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up a few plain e.printStackTrace()
calls
#9742
Conversation
And use logger with appropriate severity instead.
} catch (InterruptedException e) { | ||
// treat this as a death signal | ||
return; | ||
} catch (Throwable t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This class should just be moved to https://github.com/jenkinsci/external-monitor-job-plugin/blob/9fc4fed70ffac8b8c52288359c7854bffcb498c4/src/main/java/hudson/model/ExternalJob.java#L46 anyway.
} catch (InterruptedException e) { | ||
// treat this as a death signal | ||
return; | ||
} catch (Throwable t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This class should just be moved to https://github.com/jenkinsci/external-monitor-job-plugin/blob/9fc4fed70ffac8b8c52288359c7854bffcb498c4/src/main/java/hudson/model/ExternalJob.java#L46 anyway.
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
And use logger with appropriate severity instead.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist