Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a few plain e.printStackTrace() calls #9742

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Sep 17, 2024

And use logger with appropriate severity instead.

Testing done

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

And use logger with appropriate severity instead.
@Vlatombe Vlatombe added the skip-changelog Should not be shown in the changelog label Sep 17, 2024
@Vlatombe Vlatombe requested a review from a team September 17, 2024 11:50
} catch (InterruptedException e) {
// treat this as a death signal
return;
} catch (Throwable t) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/java/hudson/model/AbstractItem.java Outdated Show resolved Hide resolved
} catch (InterruptedException e) {
// treat this as a death signal
return;
} catch (Throwable t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/java/jenkins/model/Jenkins.java Outdated Show resolved Hide resolved
core/src/main/java/hudson/model/ViewJob.java Outdated Show resolved Hide resolved
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 18, 2024
@timja timja merged commit f9fef61 into jenkinsci:master Sep 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants