Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized / reworked 0130-WebUI-Fix-ChannelSysVarPrefix.patch #2589

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Baxxy13
Copy link
Contributor

@Baxxy13 Baxxy13 commented Jan 5, 2024

Description

  • returns the prefixes 'optical signal' / acoustical signal' to then-actions for HmIP-ASIR in webui-programs
  • retains the original function of the patch, don't show the prefixes for channel assigned system variables

Related Issue

none

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

none

Possible Drawbacks

not known

Verification Process

Implemented this optimized patch on my testsystem with HmIP-ASIR.
Checked "then-actions" on ASIR alarm-channel and on devices with channel assigned system variables.
No problems found so far.

Release Notes

Returns the prefixes 'optical signal' / acoustical signal' to then-actions for HmIP-ASIR alarm-channel in webui-programs.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

- optimizes 0130-webui-patch
@jens-maus
Copy link
Owner

Danke @Baxxy13 für diesen neuerlichen WebUI patch. Kannst du bitte hier noch zusätzlich ein paar Screenshots zeigen damit man weiss was diese Änderung genau umsetzt? Danke.

@Baxxy13
Copy link
Contributor Author

Baxxy13 commented Jan 5, 2024

original Patch:
RM_WebUI_Patch130_orig
updated Patch:
RM_WebUI_Patch130_modified

@jens-maus jens-maus added 🏷️ WebUI This refs the WebUI component 💡 enhancement-ideas New feature or change request labels Jan 5, 2024
@jens-maus jens-maus added this to the next release milestone Jan 5, 2024
@jens-maus jens-maus added 🐛 bug-report Something isn't working and removed 💡 enhancement-ideas New feature or change request labels Jan 5, 2024
@jens-maus jens-maus merged commit b4e08a7 into jens-maus:master Jan 5, 2024
8 checks passed
@Baxxy13 Baxxy13 deleted the optimized-0130-webui-patch branch January 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants