Modify ruletypes.rst, alerts.py, schema.yaml and add / modify test code for alerts_test.py #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de for alerts_test.py
ruletypes.rst
Command
Added description of fail_on_non_zero_exit
EMail
Partially modified the description of email_format
OpsGenie
Partial correction of description
Zabbix
Partial correction of description
alerts.py
EmailAlerter
Set default value for smtp_port
HTTPPostAlerter
Added mandatory check for http_post_url
DiscordAlerter
Add comment
schema.yaml
Add items that have not been added.
Change the order of alerter settings to the order of documents.
alerts_test.py
add
test_ms_teams_ea_exception
test_slack_ea_exception
test_http_alerter_post_ea_exception
test_pagerduty_ea_exception
test_alerta_ea_exception
test_datadog_alerterea_exception
test_pagertree_ea_exception
test_line_notify_ea_exception
test_gitter_ea_exception
test_chatwork_ea_exception
test_telegram_ea_exception
test_service_now_ea_exception
test_victor_ops_ea_exception
test_google_chat_ea_exception
test_discord_ea_exception
test_dingtalk_ea_exception
test_mattermost_ea_exception
modify
test_email
test_email_with_unicode_strings
test_email_with_auth
test_email_with_cert_key
test_email_with_cc
test_email_with_bcc
test_email_with_cc_and_bcc
test_email_with_args
test_command
…into add_testcode3
jertel
approved these changes
May 9, 2021
There was a problem hiding this comment.
Thanks for the schema updates and additional tests @nsano-rururu.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruletypes.rst
alerts.py
schema.yaml
alerts_test.py