Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fields types error on instance indexer_alert_config in schema.yml #1499

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

OlehPalanskyi
Copy link
Contributor

@OlehPalanskyi OlehPalanskyi commented Jul 17, 2024

Description

Hi, I saw that I made some mistakes when adding field types to the schema.yml.
I fixed and tested it.

Now it works well

  indexer_alert_config:
    type: object
    minProperties: 1
    patternProperties:
      "^.+$":
        oneOf:
          - type: [boolean, string, integer]
          - type: array
            items:
                type: object
                properties:
                  name: { type: string , minLength: 1 }
                  value: { type: [boolean, string, integer] , minLength: 1 }
                  "^.+$": { type: [boolean, string, integer], minLength: 1 }
          - type: object
            properties:
              "^.+$": { type: [boolean, string, integer], minLength: 1 }
indexer_alert_config:

  rule:
    - name: true (boolean type)
      value: name
    - name: index
      value: index
    - name: query
      value: filter

image

indexer_alert_config:

  rule:
    - name: name (string type)
      value: name
    - name: index
      value: index
    - name: query
      value: filter

image

Sorry about that

Checklist

  • I have reviewed the contributing guidelines.
  • [ ] I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • [ ] I have updated the documentation.
  • I have updated the changelog.

@OlehPalanskyi OlehPalanskyi changed the title fixed error on instance indexer_alert_config in schema.yml fixed fields types error on instance indexer_alert_config in schema.yml Jul 17, 2024
@jertel
Copy link
Owner

jertel commented Jul 17, 2024

Thanks for the correction. Please add the changelog entry, conforming to the required pattern shown in the older, existing changelog entries.

@jertel jertel merged commit 6b58dc3 into jertel:master Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants