Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ssh known hosts addition prompt #3725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gmlexx
Copy link
Contributor

@gmlexx gmlexx commented Jul 8, 2024

  • PR Description

Show acknowledgement dialog if ssh host key is not known by any other names.

image

Fix #3205.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@gmlexx gmlexx force-pushed the known-hosts-ack branch 2 times, most recently from d1b8a7e to a148b39 Compare July 8, 2024 20:06
@jesseduffield
Copy link
Owner

Thanks for raising this @gmlexx . Could you update the confirmation message so that it's clear that it's talking about an unknown SSH host? The user may not have the command log showing.

@gmlexx
Copy link
Contributor Author

gmlexx commented Aug 31, 2024

@jesseduffield it looks like prompt input doesn't have this information, it's just the line Are you sure you want to continue connecting ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Answer prompt within LazyGit
2 participants