Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow Reactive Stream TCK for ContentSourcePublisher implementation #11803

Closed
scrat98 opened this issue May 16, 2024 · 0 comments · Fixed by #11849
Closed

Follow Reactive Stream TCK for ContentSourcePublisher implementation #11803

scrat98 opened this issue May 16, 2024 · 0 comments · Fixed by #11849
Labels
Enhancement

Comments

@scrat98
Copy link
Contributor

scrat98 commented May 16, 2024

Jetty version(s)
12.0.x

Enhancement Description
The suggestion to implement one well tested "iterator" over all chunks in the Content.Source that can be used for all Content.Source "readers" (such as ContentSourceByteBuffer, ChunkAccumulator, ContentSourceString, etc). For that it makes sense to use ContentSourcePublisher meanwhile align it with Reactive Streams specification.

Related issues: #11758, #11756, #11755
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 16, 2024
@scrat98
Issue jetty#11803 - Follow Reactive Streams specification
f2dbc2d
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 16, 2024
@scrat98
Issue jetty#11803 - upgrade testng version
5c25536
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 16, 2024
@scrat98
Issue jetty#11803 - workaround for HttpChannelState
9e9ed21
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 17, 2024
@scrat98
Issue jetty#11803 - support testng with maven-surefire-plugin
b88ae63
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 21, 2024
@scrat98
Issue jetty#11803 - code review refactoring
84b0c61
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 25, 2024
@scrat98
Issue jetty#11803 - use Objects.requireNonNull
7e1a83d
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 25, 2024
@scrat98
Issue jetty#11803 - remove unused reactive-streams deps
f410849
scrat98 added a commit to scrat98/jetty.project that referenced this issue May 26, 2024
@scrat98
Issue jetty#11803 - use static exception for normal completion
b60fca3
@gregw gregw mentioned this issue May 28, 2024
Merged
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - Follow Reactive Streams specification
703de29
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - upgrade testng version
1b657f7
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - workaround for HttpChannelState
86ef501
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - support testng with maven-surefire-plugin
14a762a
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - code review refactoring
c1958ab
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - use Objects.requireNonNull
767cc06
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - remove unused reactive-streams deps
b35e79d
olamy pushed a commit that referenced this issue May 29, 2024
@scrat98 @olamy
Issue #11803 - use static exception for normal completion
36c4812
scrat98 added a commit to scrat98/jetty.project that referenced this issue Jun 5, 2024
@scrat98
Issue jetty#11803 - SyntheticContentSource: replace todo with note
5a54e00
scrat98 added a commit to scrat98/jetty.project that referenced this issue Jun 5, 2024
@scrat98
Issue jetty#11803 - refactoring
524988c
scrat98 added a commit to scrat98/jetty.project that referenced this issue Jun 6, 2024
@scrat98
Issue jetty#11803 - remove unused Cancelled exception
5a38816
scrat98 pushed a commit to scrat98/jetty.project that referenced this issue Jun 12, 2024
@gregw @scrat98
Issue jetty#11803 - updates from review
665b10e
gregw added a commit that referenced this issue Jun 13, 2024
@gregw @scrat98 @olamy
Simplified Reactive Stream update for ContentSourcePublisher (#11849)
d345567 
* Issue #11803 - Follow Reactive Streams specification
* Simplification of #11804 for Reactive Stream specification support

---------

Co-authored-by: Artem Golovko <artemgolovko98@gmail.com>
Co-authored-by: Olivier Lamy <olamy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplified Reactive Stream update for ContentSourcePublisher jetty/jetty.project
1 participant
@scrat98