Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoSFilter leaks USER_AUTH entries #1256

Closed
sbordet opened this issue Jan 11, 2017 · 5 comments · Fixed by #10748
Closed

DoSFilter leaks USER_AUTH entries #1256

sbordet opened this issue Jan 11, 2017 · 5 comments · Fixed by #10748
Assignees
@gregw
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 11, 2017

DoSFilter automatically removes RateTracker entries that belong to type USER_IP or USER_SESSION, but not the other types.

DoSFilter also needs a code review because for example exposes RateTracker as a return type of a public method, but RateTracker is package private and so it's not possible to override the method.
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Nov 21, 2019
@stale
Copy link

stale bot commented Nov 21, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 21, 2020
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Nov 21, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label May 16, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label May 17, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label May 18, 2023
@gregw
Copy link
Contributor

gregw commented May 18, 2023

6 year and counting! We should make this a priority once jetty 12 is released

@github-actions github-actions bot removed the Stale For auto-closed stale issues and pull requests label May 19, 2023
gregw added a commit that referenced this issue Oct 18, 2023
@gregw
Simplify the DosFilter for #1256
d55eb31 
Use only IP tracking for the DosFilter to fix #1256

Signed-off-by: gregw <gregw@webtide.com>
@gregw gregw mentioned this issue Oct 18, 2023
Merged
gregw added a commit that referenced this issue Oct 18, 2023
@gregw
Simplify the DosFilter for #1256
9a2dc05 
Use only IP tracking for the DosFilter.

Signed-off-by: gregw <gregw@webtide.com>
gregw added a commit that referenced this issue Oct 18, 2023
@gregw
Simplify the DosFilter for #1256 (#10748)
168d871 
Use only IP tracking for the DosFilter to fix #1256

Signed-off-by: gregw <gregw@webtide.com>
gregw added a commit that referenced this issue Oct 18, 2023
@gregw
Simplify the DosFilter for #1256 (#10748)
de862c5 
Use only IP tracking for the DosFilter to fix #1256

Signed-off-by: gregw <gregw@webtide.com>
gregw added a commit that referenced this issue Oct 18, 2023
@gregw
Simplify the DosFilter for #1256
78f3b5c 
Use only IP tracking for the DosFilter.
Fix defaults

Signed-off-by: gregw <gregw@webtide.com>
@wendigo wendigo mentioned this issue Nov 17, 2023
Closed
@joakime joakime added the Bug For general bugs on Jetty side label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.3 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify the DosFilter for #1256 jetty/jetty.project
3 participants
@gregw @joakime @sbordet