Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response to debug log event in HttpSender#failRequest() #11878

Conversation

garydgregory
Copy link
Contributor

@garydgregory garydgregory commented Jun 5, 2024

While debugging a random failure in a large and complex test suite of mine, I found it helpful to be able to see in one log event the response and its status code matched up with the request. In my case, I could see that my failure was related to processing taking place during an "Expect 100" exchange.

Signed-off-by: Gary Gregory <garydgregory@gmail.com>
@garydgregory
Copy link
Contributor Author

I see a test failure: DistributionTests.testEEFastCGIProxying:1501 expected: <true> but was: <false> but I do not understand how it relates to this change.

@olamy olamy merged commit 1f78946 into jetty:jetty-12.0.x Jun 6, 2024
10 checks passed
@garydgregory garydgregory deleted the 12.x-HttpSender-failRequest-debug-log-response branch June 6, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants