Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12.0.x object identity ee8 and ee9 #11888

Merged
merged 23 commits into from
Jun 20, 2024

Conversation

janbartel
Copy link
Contributor

@janbartel janbartel commented Jun 6, 2024

Fix to maintain object wrapper identity during cross context dispatch, only for ee8 & 9.

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly javadoc changes... but I have one concern about EE10 to EE9 dispatch session management.

@janbartel janbartel requested a review from gregw June 11, 2024 07:25
+ Removed JSON
+ Collapsed Steps
+ Simplified plan text
gregw
gregw previously approved these changes Jun 11, 2024
…-2' into jetty-12.0.x-object-identity-ee8-and-ee9
@janbartel janbartel requested a review from gregw June 19, 2024 06:45
@janbartel
Copy link
Contributor Author

@gregw can I get a re-review? The jenkins failure is nothing to do with this PR, its a HTTP2 test failure.

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks like a flake

@janbartel janbartel merged commit fd263c7 into jetty-12.0.x Jun 20, 2024
10 checks passed
@janbartel janbartel deleted the jetty-12.0.x-object-identity-ee8-and-ee9 branch June 20, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants