New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for MultiPart in jetty-core #11906

Merged

lachlan-roberts merged 12 commits into jetty-12.0.x from jetty-12.0.x-coreMultiPart

Jun 26, 2024

Contributor

lachlan-roberts commented Jun 11, 2024

Extracting the multipart changes originally made for PR #11883 and extracted to a separate PR.

This adds the class org.eclipse.jetty.server.MultiPartFormFields which can be used to parse multipart from a Core Handler.

lachlan-roberts added 3 commits

June 11, 2024 19:01


          Improve support for MultiPart in jetty-core

76cf685

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          Improve support for MultiPart in jetty-core

9862e2e

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          fix failing tests

362b582

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

lachlan-roberts requested review from gregw and sbordet

June 11, 2024 14:17

joakime requested changes

View reviewed changes

Contributor

joakime left a comment

needs more documentation

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormFields.java Outdated Show resolved Hide resolved

sbordet requested changes

View reviewed changes

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Show resolved Hide resolved

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartConfig.java Outdated Show resolved Hide resolved

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormFields.java Outdated Show resolved Hide resolved

gregw reviewed

View reviewed changes

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormFields.java Outdated Show resolved Hide resolved

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormFields.java Outdated Show resolved Hide resolved

lachlan-roberts added 2 commits

June 17, 2024 13:37


          PR #11906 - changes from review

3dcf266

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          PR #11906 - fix to MultiPartCaptureTest

6661eea

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

lachlan-roberts requested review from sbordet, joakime and gregw

June 18, 2024 05:59

sbordet previously requested changes

View reviewed changes

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartConfig.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartConfig.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Show resolved Hide resolved


          PR #11906 - changes from review

0fe432b

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

lachlan-roberts requested a review from sbordet

June 19, 2024 02:08

janbartel mentioned this pull request

Issue #11560 - Implement EIP-4361 Sign-In With Ethereum #11883

Closed

gregw requested changes

View reviewed changes

Contributor

gregw left a comment

I've got to look at a few more things, but I thought I'd give you my main feedback now.

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Show resolved Hide resolved


          PR #11906 - changes from review

65fa7af

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

gregw requested changes

View reviewed changes

Contributor

gregw left a comment

Just inline the usage of the weird from and I'm good.

Feel free to implement the class hash as well if you are keen... but that is orthogonal.

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Show resolved Hide resolved

joakime reviewed

View reviewed changes

jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/MultiPartCaptureTest.java Show resolved Hide resolved

lachlan-roberts added 3 commits

June 24, 2024 11:48


          PR #11906 - changes from review

4a33439

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          PR #11906 - changes from review

9de9a48

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          Merge remote-tracking branch 'origin/jetty-12.0.x' into jetty-12.0.x-…

c7249c7

…coreMultiPart

lachlan-roberts requested review from joakime and gregw

June 24, 2024 02:51

gregw requested changes

View reviewed changes

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPartFormData.java Outdated Show resolved Hide resolved

lachlan-roberts added 2 commits

June 24, 2024 15:32


          Issue #11906 - changes from review

c845b55

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>


          Issue #11906 - change default of useFilesForPartsWithoutFileName to true

af0902f

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>

lachlan-roberts requested a review from gregw

June 24, 2024 05:43

gregw approved these changes

View reviewed changes

joakime approved these changes

View reviewed changes

lachlan-roberts dismissed sbordet’s stale review

June 26, 2024 02:57

review addressed

lachlan-roberts merged commit f21bbcf into jetty-12.0.x

10 checks passed

lachlan-roberts deleted the jetty-12.0.x-coreMultiPart branch

June 26, 2024 02:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet