Make the Content.Chunk.isTerminal() contract stricter
#8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
changed the title
Content.Chunk.isTerminal() contract stricter
gregw
reviewed
Dec 1, 2022
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
gregw
approved these changes
Dec 1, 2022
lorban
commented
Dec 2, 2022
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ChunksContentSource.java
Show resolved
Hide resolved
lorban
commented
Dec 2, 2022
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ByteBufferContentSource.java
Outdated
Show resolved
Hide resolved
lorban
commented
Dec 2, 2022
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
|
@gregw I answered your question w.r.t succeeding twice the callback in your code comment. In a nutshell, it's never succeeded twice and my original change introduced a bug which made it never be succeeded in certain cases. This is now fixed with some comments explaining the somewhat baroque logic. |
sbordet
requested changes
Dec 5, 2022
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ChunksContentSource.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Dec 5, 2022
jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/MultiPartTest.java
Show resolved
Hide resolved
...t/src/main/java/org/eclipse/jetty/http2/client/transport/internal/HttpReceiverOverHTTP2.java
Outdated
Show resolved
Hide resolved
...-http2-server/src/main/java/org/eclipse/jetty/http2/server/internal/HttpStreamOverHTTP2.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/eclipse/jetty/http3/client/transport/internal/HttpReceiverOverHTTP3.java
Outdated
Show resolved
Hide resolved
...-http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/HttpStreamOverHTTP3.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Dec 6, 2022
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MultiPart.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/AsyncContent.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ByteBufferContentSource.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/test/java/org/eclipse/jetty/io/AsyncContentSourceTest.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/MockHttpStream.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/MockHttpStream.java
Outdated
Show resolved
Hide resolved
...etty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletMultiPartFormData.java
Outdated
Show resolved
Hide resolved
lorban
force-pushed
the
jetty-12.0.x-8993-isTerminal-eof
branch
from
84eddd6
to
cc5dedc
Compare
… Chunk.isTerminal() contract stricter Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
jetty-12.0.x-8993-isTerminal-eof
branch
from
cc5dedc
to
f510986
Compare
sbordet
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
Content.Chunk.isTerminal()contract stricter by explicitly disallowing the creation of new last chunks with an emptyByteBuffer.Also replace non-last empty chunks with EMPTY where it makes sense.
Closes #8993