Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Disabled from jetty-jmx #9143

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jan 9, 2023

Removing @Disabled annotation from jetty-core/jetty-jmx tests

@joakime joakime added this to the 12.0.x milestone Jan 9, 2023
@joakime joakime requested a review from sbordet January 9, 2023 16:09
@joakime joakime self-assigned this Jan 9, 2023
@joakime joakime requested a review from sbordet January 9, 2023 16:58
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However, I'm worried that because this test uses default ports (1099) that might be taken already.
We'll see if CI passes.

@joakime joakime merged commit b4d274e into jetty-12.0.x Jan 9, 2023
@joakime
Copy link
Contributor Author

joakime commented Jan 9, 2023

@sbordet it's green. yay!

Merging.

@joakime joakime deleted the fix/jetty-12.0.x/enabled-jmx-tests branch January 9, 2023 21:21
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Jan 16, 2023
…x-document-modules

* upstream/jetty-12.0.x:
  Issue jetty#9167 - making assumption in flaky test
  jetty 12.0.x cleanup duplicate osgi pom metadata (jetty#9093)
  Jetty 12 - Add tests in util/resource for alternate FileSystem implementations (jetty#9149)
  Cleanup non-retainable `Retainable`s (jetty#9159)
  Fixes retainability of special Chunks (jetty#9073)
  TCK: Dispatch forward and includes attributes do not meet the spec (jetty#9074)
  re-enable h3 tests (jetty#8773)
  More fundamental test case
  Reorganization of jetty-client classes. (jetty#9127)
  Removing @disabled from SslUploadTest
  Removing @disabled from jetty-start
  jetty#9134 added test
  ee10: DefaultServlet: Replace checks for isStreaming() by !isWriting()
  jetty#9078 make HttpContent.getByteBuffer() implementations return new ByteBuffer instances and document that contract
  Fixes jetty#9141 - Thread-safe Content.Chunk#slice (jetty#9142)
  Remove `@Disabled` from `jetty-jmx` (jetty#9143)
  Bump maven.version from 3.8.6 to 3.8.7
  Bump maven.version from 3.8.6 to 3.8.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants