Add latency recording utility handler #9172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got an example of how it would be used? |
gregw
approved these changes
Jan 17, 2023
...y-server/src/main/java/org/eclipse/jetty/server/handler/AbstractLatencyRecordingHandler.java
Outdated
Show resolved
Hide resolved
...y-server/src/main/java/org/eclipse/jetty/server/handler/AbstractLatencyRecordingHandler.java
Outdated
Show resolved
Hide resolved
|
@joakime The fact that you made this comment means a test is needed, at least as some internal doc showing how this works. I've now added such test. |
gregw
reviewed
Jan 18, 2023
...y-server/src/main/java/org/eclipse/jetty/server/handler/AbstractLatencyRecordingHandler.java
Outdated
Show resolved
Hide resolved
lorban
force-pushed
the
jetty-12.0.x-8069-latency-recording-handler
branch
from
1cd5831
to
451ead8
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
jetty-12.0.x-8069-latency-recording-handler
branch
from
451ead8
to
4977f7d
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
jetty-12.0.x-8069-latency-recording-handler
branch
from
4977f7d
to
be93d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small utility handler that standardizes the way latencies should be recorded.
Closes #8069.