Fixes #9288 - Jetty 12 - Use oej.http.HttpCookie in jetty-client. #9289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
force-pushed
the
fix/jetty-12-review-client-cookies
branch
from
7a3d7e2
to
7357322
Compare
sbordet
force-pushed
the
fix/jetty-12-review-client-cookies
branch
from
7111a7e
to
efe58fe
Compare
gregw
reviewed
Feb 4, 2023
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
* Replaced usages of java.net.HttpCookie with oej.http.HttpCookie. * Moved server-side only methods from HttpCookie to HttpCookieUtils. * Introduced and implemented oej.http.HttpCookieStore. * Removed now obsolete oej.util.HttpCookieStore. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
force-pushed
the
fix/jetty-12-review-client-cookies
branch
from
efe58fe
to
4b7d274
Compare
|
@sbordet please don't force push. There is no need for that as we squash when we merge. |
gregw
approved these changes
Feb 7, 2023
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookieStore.java
Show resolved
Hide resolved
jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpDestination.java
Show resolved
Hide resolved
jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpDestination.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpDestination.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this pull request
Feb 7, 2023
…x-documentation-operations-logging * upstream/jetty-12.0.x: Jetty 12: Cleanup `StatisticsHandler` (jetty#9291) Fixes jetty#9288 - Jetty 12 - Use oej.http.HttpCookie in jetty-client. (jetty#9289) Redo Handler renaming (jetty#9318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simone Bordet simone.bordet@gmail.com