PKCS12 client certificates #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunemaker
pushed a commit
that referenced
this pull request
Oct 22, 2013
PKCS12 client certificates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I had to connect to a remote service using a password protected private key file.
The
:pemoption didn't seem to allow me to generate anOpenSSL::X509::Certificateand anOpenSSL::PKey::RSAin the right way, although I was able to manually build an HTTP connection usingOpenSSL::PKCS12.new.In the end I extended
ConnectionAdapterto get things working in my project, but as PKCS12 is a standard I thought I'd merge my fix back into the mainConnectionAdapterclass and let you take a look.