Merge pull request #118 from johnzuk/fix/missing-set-session

Add missing setSessionId for cache purpose #117

.github/workflows/static.yml

@@ -9,14 +9,18 @@ jobs:
     name: Composer validation
     runs-on: ubuntu-20.04
 
+    strategy:
+      matrix:
+        php: [ '8.0', '8.1', '8.2', '8.3' ]
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.0'
+          php-version: ${{ matrix.php }}
 
       - name: Execute composer validate
         run: composer validate --strict
@@ -25,14 +29,18 @@ jobs:
     name: PHPCs
     runs-on: ubuntu-20.04
 
+    strategy:
+      matrix:
+        php: [ '8.0', '8.1', '8.2', '8.3' ]
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.0'
+          php-version: ${{ matrix.php }}
 
       - name: Install Dependencies
         uses: nick-invision/retry@v1
@@ -44,19 +52,22 @@ jobs:
       - name: Execute PHPCs
         run: vendor/bin/phpcs src tests
 
-
   phpstan:
     name: PHPStan
     runs-on: ubuntu-20.04
 
+    strategy:
+      matrix:
+        php: [ '8.0', '8.1', '8.2', '8.3' ]
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.0'
+          php-version: ${{ matrix.php }}
 
       - name: Install Dependencies
         uses: nick-invision/retry@v1

UPGRADE.md

@@ -17,8 +17,6 @@ GusApi
 
 * The `GusApi::setUserKey` has been removed.
 
-* The `GusApi::setSessionId` has been removed.
-
 * The `GusApi::getResultSearchMessage` has been removed.
 
 ReportTypes

src/GusApi/GusApi.php

@@ -54,6 +54,11 @@ public function getSessionId(): string
         return $this->sessionId;
     }
 
+    public function setSessionId(string $sessionId): void
+    {
+        $this->sessionId = $sessionId;
+    }
+
     /**
      * @throws InvalidUserKeyException
      */

tests/GusApiTest.php

@@ -54,6 +54,13 @@ public function testLoginWillSetSessionId(): void
         self::assertSame('12sessionid21', $this->api->getSessionId());
     }
 
+    public function testSetSessionIdWillSetSession(): void
+    {
+        $this->api->setSessionId("12sessionid21");
+        $this->mockApiClientGetValueCall('StatusSesji', '1');
+        self::assertTrue($this->api->isLogged());
+    }
+
     public function testGetSessionIdFailsWhenNotLoggedIn(): void
     {
         $this->expectException(BadMethodCallException::class);
@@ -306,6 +313,11 @@ public function testGetSessionStatus(): void
     private function expectGetValueCall(string $parameter, string $value): void
     {
         $this->loginApiWithSessionId('12sessionid21');
+        $this->mockApiClientGetValueCall($parameter, $value);
+    }
+
+    private function mockApiClientGetValueCall(string $parameter, string $value): void
+    {
         $this->apiClient
             ->expects(self::once())
             ->method('getValue')