Added person provider for gu_IN locale with tests #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Isn't the locale code for Gujarati gu instead of gj?
https://www.loc.gov/standards/iso639-2/php/langcodes_name.php?iso_639_1=gu
debjeetsingha
changed the title
|
The error seems to be related to the use of |
fcurella
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Added male and female names with prefixes for gn_IN
Added tests for person provider
What was wrong
There was no person provider for gn_IN locale
Fixes #2106
Checklist
make lint