Don't error if git tab completion is not available. Fixes #1011 #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbronder
added a commit
to jsbronder/gentoo
that referenced
this pull request
Sep 29, 2020
The patch applied in the last bump is incorrect and effectively disables bash completion no matter what order the completions were loaded in as `type -f` will not find `__git_complete`. ``` $ type -f __git_complete bash: type: __git_complete: not found $ type __git_complete | grep 'is a' __git_complete is a function ``` There is a pull-request upstream that properly addresses the issue of `__git_complete` not being found but it's not accepted yet, jonas/tig#1016 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Justin Bronder <jsbronder@gentoo.org>
jsbronder
added a commit
to jsbronder/gentoo
that referenced
this pull request
Sep 29, 2020
The patch applied in the last bump is incorrect and effectively disables bash completion no matter what order the completions were loaded in as `type -f` will not find `__git_complete`. ``` $ type -f __git_complete bash: type: __git_complete: not found $ type __git_complete | grep 'is a' __git_complete is a function ``` There is a pull-request upstream that properly addresses the issue of `__git_complete` not being found but it's not accepted yet, jonas/tig#1016 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
iillyyaa
reviewed
Sep 29, 2020
Co-authored-by: Ilya A. Kriveshko <iillyyaa@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 3, 2020
The patch applied in the last bump is incorrect and effectively disables bash completion no matter what order the completions were loaded in as `type -f` will not find `__git_complete`. ``` $ type -f __git_complete bash: type: __git_complete: not found $ type __git_complete | grep 'is a' __git_complete is a function ``` There is a pull-request upstream that properly addresses the issue of `__git_complete` not being found but it's not accepted yet, jonas/tig#1016 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Justin Bronder <jsbronder@cold-front.org> Closes: #17715 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
NeddySeagoon
pushed a commit
to NeddySeagoon/gentoo-arm64
that referenced
this pull request
Oct 6, 2020
The patch applied in the last bump is incorrect and effectively disables bash completion no matter what order the completions were loaded in as `type -f` will not find `__git_complete`. ``` $ type -f __git_complete bash: type: __git_complete: not found $ type __git_complete | grep 'is a' __git_complete is a function ``` There is a pull-request upstream that properly addresses the issue of `__git_complete` not being found but it's not accepted yet, jonas/tig#1016 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Justin Bronder <jsbronder@cold-front.org> Closes: gentoo#17715 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
darcyparker
reviewed
Dec 2, 2020
| # variables (like cword and prev) to be defined | ||
| __git_complete tig _tig | ||
| if [ "$(type -t __git_complete)" = function ]; then |
There was a problem hiding this comment.
Nitpick... if ! declare -f __git_complete &>/dev/null; then is a better test for existence of function because it doesn't spawn shell with $()
|
See #1011 (comment). I did some analysis and found that sourcing |
|
#1055 is an alternate solution that attempts to define |
|
Yes, the approach in #1055 looks more reasonable to me than just silently doing nothing if the git completion is not loaded yet. |
|
Cool. I'll go ahead and close. Hopefully someone with write access can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like tab completion should always be a nice-to have, so made it just exit silently if git tab completions were not available. If you want I can make it print a friendly error message.
As is, users get a pretty mysterious:
And it is a little hard to know where it came from.
Fixes #1011