Disable ncurses extended keycode values. A better method than prev PR #1049

[mckellygit]

Hi,
Here is a cleaner fix than previous PR #1049
Thanks to xaizek also.
thx,
-m

[koutcher]

Have you tried mouse support after this PR ? Looks broken to me.

Btw, I'm also looking at your other PR #1060 (that's how I found out as I'm not using the mouse support otherwise), I have some changes to propose after the review, if you agree I can push them to your PR branch for you to check them.

[mckellygit]

Hi,
I just tested this PR with:

set mouse = yes
set mouse-wheel-cursor = no (and yes)

And mouse clicks seem to be ok for me.
I'll keep testing and try some different terminals.
Sure, glad to review/help out with the PR # 1060 :-)

[koutcher]

I double checked and can confirm that on macOS with Terminal, using

$ tig -v
tig version 2.5.1-48-g0bb11a2
ncursesw version 6.2.20200212
readline version 8.1

the mouse support is definitely broken while everything goes back to normal when recompiling master.
I just uncommented the #set mouse = yes in the default tigrc.

[mckellygit]

@koutcher hi,
Ok. Lets just leave it as is then, with the keyok(false) method and I'll close this PR.
I'll research it more some time in the future.

[koutcher]

The problem occurs with xterm (and derived) terminal descriptions. It seems to be linked to changes introduced in ncurses 6.1 regarding kmous capability.

My understanding is that after calling use_extended_names(false), ncurses cannot query kmous which is part of the extended set anymore and the mouse support keeps working only for terminals using the hardcoded default value \033[M.

If it is confirmed, it means that it is not correct to call use_extended_names(false) when the mouse support is required.

[mckellygit]

ok, I'll close this PR now.