Mark all Option types non_exhaustive #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
See also rust-lang/rust#70564 (comment) |
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 16 16
Lines 2238 2238
=======================================
Hits 2021 2021
Misses 217 217
Continue to review full report at Codecov.
|
jonhoo
force-pushed
the
non-exhaustive-options
branch
3 times, most recently
from
d7c5379
to
d2289af
Compare
This is a breaking change. See also rust-lang/rust#70564 (comment) for why this change is a little sad.
jonhoo
force-pushed
the
non-exhaustive-options
branch
from
d2289af
to
65f9f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.