-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use text-anchor instead of hardcoded offsets #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just one note about the new FLAMEGRAPH_BLESS
envvar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
This was proposed by `@nagisa` in jonhoo#247, I just applied the suggestions, tested that the result was as expected. I tried the suggestion of `dominant-baseline="hanging"`, but it will need further work to make it usefull as applying instead will just increase the size of the css without reducing enough in the SVG. Co-authored-by: Simonas Kazlauskas <git@kazlauskas.me> Fixes jonhoo#247
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 18 18
Lines 2541 2541
=======================================
Hits 2220 2220
Misses 321 321
Continue to review full report at Codecov.
|
Thanks! |
Released in 0.11.7 🎉 |
This was proposed by
@nagisa
in #247, I just applied the suggestions and tested that the result was as expected.I tried the suggestion of
dominant-baseline="hanging"
, but it will need further work to make it useful as applying instead will just increase the size of the CSS without reducing enough in the SVG.Fixes #247