Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse submission has extra fields #2

Closed
josephfrazier opened this issue Apr 11, 2018 · 1 comment · Fixed by #346
Closed

Parse submission has extra fields #2

josephfrazier opened this issue Apr 11, 2018 · 1 comment · Fixed by #346
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@josephfrazier
Copy link
Owner

josephfrazier commented Apr 11, 2018 •
edited
Loading

From https://reportedcab.slack.com/messages/C802R14UX/p1523482792000427:

report->>'objectId' as "objectId", -- automatically generated from parse right?
-- report->>'submission_date' as submission_date, -- readable timestamp - this isnt used on the submission but is used in iOS i think (maybe not)
-- report->>'colorTaxi' as "colorTaxi",  -i'm not automatically categorizing the vehicle based on patterns and other data!  woohoo! so this field is actually not used
report->>'passenger' as passenger, -- boolean, probably not necessary since we already have 'typeofuser' (which is passenger, pedestrian, cyclist)
report->>'typeofcomplaint' as typeofcomplaint,
report->>'medallionNo' as "medallionNo", -- probably should be simplified to 'license'
report->>'reportDescription' as "reportDescription", -- generally shouldnt be blank... but its ok
report->'photoData'->>'url' as photo_url_0, --keep using your photo objects whatever they're called
report->'photoData1'->>'url' as photo_url_1,
report->'photoData2'->>'url' as photo_url_2,
report->'videoData'->>'url' as video_url,
report->>'submission_timestamp' as submission_timestamp, -- timestamp UTC
report->>'loc1_address' as loc1_address, -- used in email template, see https://reportedcab.slack.com/messages/C9VNM3DL4/p1524530584000243
report->>'latitude' as "latitude",
report->>'longitude' as "longitude",
report->>'Username' as "Username", -- this should just be "email_id" or somethign simpler
report->>'FirstName' as "FirstName", 
report->>'LastName' as "LastName",
report->>'Phone' as "Phone",
report->>'Borough' as "Borough",
report->>'Building' as "Building",
report->>'StreetName' as "StreetName",
report->>'Apt' as "Apt"

EDIT: Here's the relevant portion of the code at the time of writing (editing): https://github.com/josephfrazier/Reported-Web/blob/c1450b8421cae9ad33db2835232d1b0b39aafb11/src/server.js#L251-L309
josephfrazier added a commit that referenced this issue Apr 23, 2018
@josephfrazier
Remove "Cab Color" field (colorTaxi)
1448312 
From #2

> `-- report->>'colorTaxi' as "colorTaxi",  -i'm not automatically categorizing the vehicle based on patterns and other data!  woohoo! so this field is actually not used`
josephfrazier added a commit that referenced this issue Apr 23, 2018
@josephfrazier
Remove unused loc1_address (formatted_address) from submission
0c1aa72 
Keep it on the form though, since it's easier to read than lat/long.

https://reportedcab.slack.com/messages/C852Q265V/p1523147911000014
#2
@josephfrazier josephfrazier added question Further information is requested help wanted Extra attention is needed labels Jun 4, 2018
@josephfrazier
Copy link
Owner Author

Closing this to clean up the issues list, and since both colorTaxi and loc1_address turned out to be needed after all. We can always re-open if it actually becomes a problem.

This was referenced Jul 7, 2022
Open
Open
josephfrazier added a commit that referenced this issue Jul 7, 2022
@josephfrazier
Disable zoom on mobile devices to avoid unescapeable map issue
740128b 
This fixes #344 by
preventing zoom entirely, on mobile devices:

> From https://reportedcab.slack.com/archives/C9VNM3DL4/p1657204889174239?thread_ts=1656783831.210109&cid=C9VNM3DL4:
>
> > > UPDATE: you appear to have fixed #2 by disabling pinching, but this also makes map view crash easily (on my first two tries, once it crashed and sent me back to Reported login, then it crashed and sent me to a Chrome "Can't open this page" (edited)
> >
> >
> > I don't think I've made any changes relating to pinching or the map in at least a year (if you're curious, you can see the list of changes here), so I'm not sure how to explain the difference in behavior you're seeing.
> > That said, I can try to discuss the issue:
> > > (2) map view issue #1: The only ways to get out of map view are (1) click one of the buttons on the bottom, or (2) touch the grayed-out part of the underlying page. If neither of those is visible, you can't get out of map view. This means that if you pinch the map out (expand it), even accidentally, so that the margin around the map itself is no longer visible, there is no way to get out of map view, you have to reload the page (and re-upload your photo or maybe start the whole report over, I can't remember). (You can't pinch it back in if the entire window is full of map.)
> >
> >
> > I'm curious how you were previously able to pinch-zoom the map/page such that neither the buttons or the margin were visible. When I try (on Android), I can either pinch the map, which only zooms the map while leaving the rest of the page alone, or I can pinch the margin, which zooms the entire page, but the margin is still visible because I'm pinching it.
> > Perhaps things behave differently on iOS?
>
> > Actually the map zoom issue is: if you are zoomed out at all when you enter map view (which you often are, especially on an iPad, and you may not realize it), you’re screwed, because you can’t zoom in (in order to see the buttons or margins, the things you have to click in order to get out of map view) if the only things your fingers can touch are the map itself
>
> > ohhh, I see now, and I was able to reproduce that issue. I wonder if there's a way to detect the zoom level, and prompt the user to zoom back out all the way before they can open the map
> > (side note, I think we're using "zoom in" and "zoom out" with opposite meanings. To me "zooming in" makes the things on screen bigger, and "zooming out" makes them smaller)
@josephfrazier josephfrazier mentioned this issue Jul 7, 2022
Merged
josephfrazier added a commit that referenced this issue Jul 8, 2022
@josephfrazier
Disable zoom on mobile devices to avoid unescapeable map issue (#346)
0ec5908 
This fixes #344 by
preventing zoom entirely, on mobile devices:

> From https://reportedcab.slack.com/archives/C9VNM3DL4/p1657204889174239?thread_ts=1656783831.210109&cid=C9VNM3DL4:
>
> > > UPDATE: you appear to have fixed #2 by disabling pinching, but this also makes map view crash easily (on my first two tries, once it crashed and sent me back to Reported login, then it crashed and sent me to a Chrome "Can't open this page" (edited)
> >
> >
> > I don't think I've made any changes relating to pinching or the map in at least a year (if you're curious, you can see the list of changes here), so I'm not sure how to explain the difference in behavior you're seeing.
> > That said, I can try to discuss the issue:
> > > (2) map view issue #1: The only ways to get out of map view are (1) click one of the buttons on the bottom, or (2) touch the grayed-out part of the underlying page. If neither of those is visible, you can't get out of map view. This means that if you pinch the map out (expand it), even accidentally, so that the margin around the map itself is no longer visible, there is no way to get out of map view, you have to reload the page (and re-upload your photo or maybe start the whole report over, I can't remember). (You can't pinch it back in if the entire window is full of map.)
> >
> >
> > I'm curious how you were previously able to pinch-zoom the map/page such that neither the buttons or the margin were visible. When I try (on Android), I can either pinch the map, which only zooms the map while leaving the rest of the page alone, or I can pinch the margin, which zooms the entire page, but the margin is still visible because I'm pinching it.
> > Perhaps things behave differently on iOS?
>
> > Actually the map zoom issue is: if you are zoomed out at all when you enter map view (which you often are, especially on an iPad, and you may not realize it), you’re screwed, because you can’t zoom in (in order to see the buttons or margins, the things you have to click in order to get out of map view) if the only things your fingers can touch are the map itself
>
> > ohhh, I see now, and I was able to reproduce that issue. I wonder if there's a way to detect the zoom level, and prompt the user to zoom back out all the way before they can open the map
> > (side note, I think we're using "zoom in" and "zoom out" with opposite meanings. To me "zooming in" makes the things on screen bigger, and "zooming out" makes them smaller)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable zoom on mobile devices to avoid unescapeable map issue josephfrazier/reported-web
1 participant
@josephfrazier