Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse the stackframe order #95

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

marcomorain
Copy link
Collaborator

The client was sending the stackframes in the opposite order to what
Sentry expects.

The client was sending the stackframes in the opposite order to what
Sentry expects.
}).get();
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException(e);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a much more meaty exception in Sentry - a chain of 3:

screen shot 2016-10-05 at 22 56 13

screen shot 2016-10-05 at 22 56 29

screen shot 2016-10-05 at 22 56 38

@marcomorain marcomorain merged commit e3aa821 into master Oct 5, 2016
@marcomorain marcomorain deleted the feature-stacktrace-order branch October 5, 2016 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant