Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DnD): use custom event wrapper component while dragging #1865

Conversation

nlevchuk
Copy link
Contributor

This change allows to use custom EventWrapper component on preview event

Closes #1864

This change allows to use custom EventWrapper component on preview event
@nlevchuk nlevchuk force-pushed the use-event-wrapper-while-dragging branch from e91490d to f181248 Compare March 5, 2021 06:10
@dhruvgoel92
Copy link
Contributor

Nice, this is useful.

@cutterbl
Copy link
Collaborator

@nlevchuk Implemented your changes in #2221 to get around branch conflicts

@cutterbl cutterbl closed this Jul 11, 2022
@nlevchuk
Copy link
Contributor Author

@cutterbl Hello. You made an identical PR (#2221) and closed mine. Why? I don't understand your point. Explain me please
I could rebase the main branch to mine one and fix conflicts if they could be

@cutterbl
Copy link
Collaborator

cutterbl commented Jul 11, 2022

@nlevchuk There were a large number of unresolved file conflicts with your branch, but your changes were easily replicated on a fresh branch. Changes are now in current build.

@nlevchuk
Copy link
Contributor Author

@cutterbl It's two-line changes. I even could create fresh branch from the main one and create new PR if you told me about it. It would save my contribution to the project

@nlevchuk
Copy link
Contributor Author

@cutterbl In modern world it calls "stolen code"

@cutterbl
Copy link
Collaborator

@nlevchuk I tell you what. I'll pull the changes out, and let you reapply. I really wasn't trying to 'steal' your code, or I wouldn't have posted anything here in the first place. I was just trying to get the changes in. Would that be OK with you?

@chuprik
Copy link

chuprik commented Jul 11, 2022

it is a shame.

@nlevchuk
Copy link
Contributor Author

nlevchuk commented Jul 11, 2022

@cutterbl I appreciate your work on the project and thank you for that.

Look at this situation from my side: One of contributors creates a PR with identical changes, merge it to the main branch, close my PR and trying to tell me that what he did is normal. What do you feel if it would happen with you?

I'll pull the changes out, and let you reapply

I guess it's fair

@cutterbl
Copy link
Collaborator

@nlevchuk Everyone has a different perspective. I was just trying to move forward a minor change that could obviously be helpful to others, but had sat for four months. But, I see your point of view as well. The changes have been pulled. Please reapply them at your earliest convenience, so that other's may benefit from the change.

@nlevchuk
Copy link
Contributor Author

@cutterbl

Everyone has a different perspective. I was just trying to move forward a minor change that could obviously be helpful to others, but had sat for four months

Even if you did your changes from the best intention you played down my work: I spent time creating the issue and the PR.
Anyway, I'm glad that we understood each other. Thank you

I'm going to make the changes right away

@nlevchuk
Copy link
Contributor Author

@cutterbl I've done it #2228. Please check this out

@nlevchuk nlevchuk deleted the use-event-wrapper-while-dragging branch July 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use custom eventWrapper component while dragging event (DnD)
4 participants