perf(parse): cache length, return early #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches
str.length
(since the string length stays the same across the function).In addition, I've also added an early return for cookie strings that are below the min. spec length and added a test for that.
Explanation
Previously, for e.g. empty strings as input we did the following things:
var opt = options || {};
var dec = opt.decode || decode
while (index < str.length)
var eqIdx = str.indexOf('=', index)
if (eqIdx === -1) break
now it is only
if (length < 2) return
, so it saves us time on early return.do-while instead of while
Since we've taken care of the min string length, we can make the assumption there should always be one run of the statement.
less allocations
By reusing the
var
s, we produce less allocations and we don't allocate a{}
in case options are missing.benchmark