"Feature: Comment Functionality Implementation" #284
Conversation
django_project/blog/models.py
Outdated
| ordering = ["date_posted"] | ||
|
|
||
| def __str__(self): | ||
| return "Comment \"{}\" {} by {}".format(self.content[3:20] , "... ",self.author) |
There was a problem hiding this comment.
Knitpick...but could we use an f-string instead of .format? I believe .format() is a legacy thing.
There was a problem hiding this comment.
It looks like submitting the comment does a full-page refresh (I am scrolled up to the top).
It would be cool if we made this async using HTMX...You can look at my implementation of infinite scroll to get inspiration.
I am not exactly sure how it would work in this context, but essentially, you would do something like:
<section id="create-comments-section" class="content-section">
<h3>Make a Comment</h3>
<form hx-post="{% url 'comment-create' %}" hx-trigger="submit" hx-swap="beforeend" hx-target="#comments-section" method="POST" action="{% url 'comment-create' %}" enctype="multipart/form-data">
{% csrf_token %}
{{ form.media }}
{{ form }}
<button class="post-submit-button" id="post-submit-button" type="submit">Comment</button>
</form>
</section>There was a problem hiding this comment.
I think it makes more sense to just say 'Comment' rather than 'make a comment' in English. The placeholder text could be, "Leave your thoughts here..."
That's what LinkedIN does.
The text 'Content:' seems to be redundant. I suggest taking it out.
There was a problem hiding this comment.
For some reason, the htmx code doesn't work as expected. It threads the whole post under after commenting
There was a problem hiding this comment.
Okay, I can take a stab at it after the PR merges.
|
Hey, this is looking good! Nice work. Doesn't look like there is a way to edit or delete comments. I am fine if we don't put those features into this PR, but we probably want to open a new issue/PR for those additional features. |
After you merge @jsolly, I'll create issues for editing/deleting comments, and the page scroll after commenting |
|
Hey. I sent you a PR with some changes. I just noticed the build is failing with your PR. We will have to figure that out before we merge. Please make sure you are using Black and Ruff on your codebase. If Ruff has any failures, it will block the build. If you are having trouble getting those two tools setup, let me know! |
I've setup both of them, and I ran a check using black. |
django_project/users/apps.py
Outdated
There was a problem hiding this comment.
Pretty sure this code is needed. I think you might have added pass when you were trying to get the initial migration working.
I suggest we put it back to the way it was.
django_project/db.sqlite3
Outdated
There was a problem hiding this comment.
This needs to be removed from the PR. We don't commit the database file to source control.
jsolly
changed the base branch from
master
to
dependabot/pip/django_project/requirements/ipython-8.14.0
jsolly
changed the base branch from
dependabot/pip/django_project/requirements/ipython-8.14.0
to
master
|
I made all the additional changes. Merging now! |
Description
This pull request adds the functionality to create and display comments for each post. Users can now engage in discussions by leaving comments on posts.
Changes Made
Checklist
Additional Information