[Fix] jsx-no-literals: Avoid crashing on valueless boolean props
#3823
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8217ed removed the node.value check leading to this crashing on any valueless boolean prop such as <Component isWhatever /> This just readds the check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3823 +/- ##
==========================================
+ Coverage 95.97% 97.66% +1.68%
==========================================
Files 136 133 -3
Lines 9929 9917 -12
Branches 3677 3678 +1
==========================================
+ Hits 9529 9685 +156
+ Misses 400 232 -168 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b8217ed removed the
node.valuecheck leading to this crashing on any valueless boolean prop such as<Component isWhatever />This just readds the check.
Fixes #3820