Dependency Update: webkit2gtk4.0 -> webkit2gtk4.1 #1404
Conversation
There was a problem hiding this comment.
According to this very doc v4.1 is already the standard as it says on older systems you can use 4.0.
There was a problem hiding this comment.
I think you need to revisit this PR. You can see in the code below that it is already pulling v4.1 with v4.0 as a fallback, but your change eliminates the fallback and doesn't seem to have any benefit.
There was a problem hiding this comment.
Oh you're right. I just did a naive find and replace here. I'll update this on my next revision.
There was a problem hiding this comment.
I've actually been digging into this myself in a JUCE 6 based project today. I found I also needed to swap some code out in the jucer_ProjectExporter.cpp file, not sure if it's relevant in the latest JUCE but I'll leave it here in case you need it.
if (isWebBrowserComponentEnabled (project) && type == PackageDependencyType::compile)
{
if (library.open ("libwebkit2gtk-4.1.so"))
packages.add ("webkit2gtk-4.1");
else
packages.add ("webkit2gtk-4.0");
packages.add ("gtk+-x11-3.0");
}
|
@davidhealey - I appreciate your feedback on this PR. I think this feature is included in a more pragmatic way in the latest |
Addresses #1377
I'm not knowledgeable enough with C++/CMake for it to be obvious to me how to allow either version of this dependency. Would love some feedback if this is possible so I don't break any builds that cannot install webkit2gtk-4.1 for some reason.
This was a simple find&replace. I'm not sure if there's anything else to update here.