Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fsGroup from the Pod's securityContext to determine uid/gid for mount opts #9

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

juliohm1978
Copy link
Owner

No description provided.

@juliohm1978 juliohm1978 added the enhancement New feature or request label Nov 5, 2019
@spawnia
Copy link
Contributor

spawnia commented Nov 5, 2019

This is not working in Kubernetes versions below v1.15 (i tried in v1.14.8).

I dug in and found that the input for fsGroup is different than you expected:

{
  "kubernetes.io/fsGroup": "33",
  ...
}

The rest of the arguments is passed as expected.

Looks like that change was made in v1.15: kubernetes/kubernetes@5b97b28
Everything works fine there, nicely done!

How about we add in a fallback to look in both fields?

@juliohm1978 juliohm1978 closed this Nov 5, 2019
@juliohm1978 juliohm1978 reopened this Nov 5, 2019
@juliohm1978
Copy link
Owner Author

New commit coming later

@juliohm1978
Copy link
Owner Author

A new 0.5-beta was built on top of the existing. I'll run some tests here and let you know.

@juliohm1978
Copy link
Owner Author

Seems ok on v1.14.8 now. Will post a new release as soon as I get a feedback.

@spawnia
Copy link
Contributor

spawnia commented Nov 7, 2019

It worked great.

Thank you for implementing this, it was great to peek into the inner workings a little bit. Interesting stuff.

@juliohm1978 juliohm1978 merged commit 63f25f0 into master Nov 7, 2019
@juliohm1978 juliohm1978 deleted the fsgroup branch April 16, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants