Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new border style: 'thinblock' #3327

Merged
merged 4 commits into from
Jun 10, 2023
Merged

Conversation

mikesmithgh
Copy link
Contributor

I saw that you recently added the block border and would like to introduce a thinblock border as well. It is using the symbols from https://www.unicode.org/charts/PDF/U1FB00.pdf Symbols for Legacy Computing, ONE EIGHTH BLOCK elements.

I searched for all places with BorderBlock and added BorderThinBlock. One thing to note about the symbols is that they a font specific, and may not exist or may not align perfectly depending on the font and terminal emulator. In the case of Kitty terminal, box drawings are handled by Kitty rather than the font so it appears correctly regardless of the font.

MonaLisa font missing the corner symbols in Alacritty:
Alacritty MonaLisa
Iosevka font in Alacritty
Alacritty Iosevka
Iosevka font in Wezterm
Wezterm Iosevka
Iosevka font in iTerm2
iTerm2 Iosevka
MonaLisa font in Kitty
Kitty MonaLisa

MonaLisa Font: https://www.monolisa.dev/
Iosevka Font: https://github.com/ryanoasis/nerd-fonts/releases/download/v3.0.2/Iosevka.zip

Please let me know what you think. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@junegunn
Copy link
Owner

junegunn commented Jun 9, 2023

Thanks, I like it. I would like to have a more terse name than thinblock, but I can't think of a better one.

Unfortunately, it's not properly rendered on iTerm2 with the default font I use, but I can confirm that it's properly supported in other emulators.

On Hyper terminal

image

@mikesmithgh
Copy link
Contributor Author

Thanks, I like it. I would like to have a more terse name than thinblock, but I can't think of a better one.

Unfortunately, it's not properly rendered on iTerm2 with the default font I use, but I can confirm that it's properly supported in other emulators.

On Hyper terminal

image

Thanks. Yeah, I wasn't sold on thinblock either 😂. I think one-eighth-block would be the most accurate. But, I kind of like narrow. Here are a couple that came to the top of my head:

--border=one-eighth-block
--border=narrow-block
--border=narrow
--border=thinblock
--border=solid
--border=thin
--border=line
--border=outline
--border=edge

Another option is to allow a custom block and the user specifies the characters in a comma delimited list.

@junegunn
Copy link
Owner

junegunn commented Jun 10, 2023

Let's just go with thinblock. I think we need to keep block in its name as we can see it as an alternative to the existing, more widely supported block and it shares the same properties of it (i.e. good for different background color)

@junegunn junegunn merged commit ce8a745 into junegunn:master Jun 10, 2023
@junegunn
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants