Add reference to ExpectedException. Fixes #806. #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junit-team As an alternative we could write something like
|
| * </pre></p> | ||
| * </pre> | ||
| * If the exception's message or one of its properties should be verified, the | ||
| * {@link org.junit.rules.ExpectedException} can be used. |
There was a problem hiding this comment.
could you either add the word "rule" before the word "can", or remove the word "the" at the end of the previous line?
|
@stefanbirkner I think your current wording is fine. I am not sure if we want to have the Javadoc tell people to prefer |
The ExpectedException can be used for better exception testing. The reference should guide the reader to its documentation.
|
@kcooney I added the reference to the JUnit Wiki and removed the recommendation for |
kcooney
added a commit
that referenced
this pull request
Feb 4, 2014
Add reference to ExpectedException. Fixes #806.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ExpectedException can be used for better exception testing. The
reference should guide the reader to its documentation.