Upgrade to Spotless 2.0

[sbrannen]

Status Quo

Spotless 2.0 should fix issues regarding EOL characters on Windows (see diffplug/spotless#23).

Related Issues

• Cannot build JUnit 5 on Microsoft Windows #398

Deliverables

• Upgrade to Spotless 2.0 once it is released.

[nedtwigg]

Just FYI, Spotless 2.0 is now available.

I think right now you've got something like this:

spotless {
    ...
    lineEndings 'UNIX'
}

You shouldn't need to specify lineEndings any longer - it will automatically use the same line endings policy as git.

[sbrannen]

Hi @nedtwigg,

Thanks for the heads up and congratulations on releasing Spotless 2.0!

I just tried it locally, and it works fine.

As for removing the explicit lineEndings declaration, we do not currently have a custom .gitattributes file in place. So, please correct me if I'm wrong, but... my understanding is that the default settings (and search algorithm for custom line ending settings) in Spotless 2.0 won't help us unless we create such a custom .gitattributes file.

Can you please confirm the above assumption?

Cheers,

Sam

[sbrannen]

in progress

[sbrannen]

@nedtwigg,

The latest build on Windows just passed.... with the Spotless lineEndings configuration removed:

https://ci.appveyor.com/project/marcphilipp/junit5/build/101

So, maybe we can just assume it's working properly, ... but a confirmation would still be nice. 😉

[nedtwigg]

You do have a .gitattributes file:

https://github.com/junit-team/junit5/blob/master/.gitattributes, added in dc5e875

and so everything is working properly.

If you didn't have a .gitattributes file, then git would check them out as \r\n, and if you have tests which rely on line ending (which I believe you do), then you'd have problems. And you could tell spotless lineEndings 'UNIX', but the problem then would be that the build would fail until you called spotlessApply. And once you called spotlessApply, everything in the working tree would be marked dirty, so you had to tell spotless AND .gitattributes.

Before spotless 2.0, it was really important to synchronize git and spotless on the line ending. Now they're always synchronized unless you go out of your way to manually specify a line ending to spotless.

[sbrannen]

@nedtwigg, well... you're totally correct!

I must be getting senile, since I'm the one who created that .gitattributes file. 😉

Thanks for reminding me,

Sam