Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ssl_version as a JKG config option #340

Merged
merged 5 commits into from
Aug 17, 2020
Merged

enable ssl_version as a JKG config option #340

merged 5 commits into from
Aug 17, 2020

Conversation

applecool
Copy link
Contributor

Fixes #339

kevin-bates
kevin-bates reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @applecool. I just had a few comments.

kernel_gateway/gatewayapp.py Outdated Show resolved Hide resolved
kernel_gateway/gatewayapp.py Outdated Show resolved Hide resolved
kernel_gateway/tests/test_gatewayapp.py Outdated Show resolved Hide resolved
kernel_gateway/tests/test_gatewayapp.py Show resolved Hide resolved
@applecool
Copy link
Contributor Author

@kevin-bates Please take a look :)

kevin-bates
kevin-bates reviewed Aug 17, 2020
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good and testing fine. Just had the comments regarding dependency on the other items.

kernel_gateway/gatewayapp.py Outdated Show resolved Hide resolved
kernel_gateway/tests/test_gatewayapp.py Show resolved Hide resolved
kevin-bates
kevin-bates approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @applecool - thank you!

If you're so inclined, we could certainly use this change in Enterprise Gateway as well!

@kevin-bates kevin-bates merged commit 894bef4 into jupyter-server:master Aug 17, 2020
@applecool
Copy link
Contributor Author

Thank you :) Should I create the issue on that repo or can I just reference the above issue in that repo?

@applecool applecool deleted the add-ssl-version branch August 17, 2020 21:21
@kevin-bates
Copy link
Member

Referencing the issue in a pull request is fine. Thank you!!

@kevin-bates
Copy link
Member

Thanks for your contributions @applecool - I'll try to cut 2.4.3 by end of day tomorrow.

@applecool
Copy link
Contributor Author

Awesome. Thank you so much. Really appreciate it :)

@kevin-bates
Copy link
Member

JKG 2.4.3 is now up on pypi.

@applecool
Copy link
Contributor Author

Hey @kevin-bates Is it also available on conda default or conda-forge channel?

@kevin-bates
Copy link
Member

It should be on conda-forge although I just now merged the PR.

@applecool
Copy link
Contributor Author

Sweet. I can see it on conda-forge :) I believe the main channel (default) would be next 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to connect to jupyter kernel gateway on Safari Version >= 13.1
2 participants
@applecool @kevin-bates