Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _compare_mimedata #492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrisjsewell
Copy link
Contributor

@chrisjsewell chrisjsewell commented Aug 8, 2019

Surprised this hasn't been noticed before. For example, this ensures minor modifications of image/svg+xml are not erroneously reported as deleted/inserted.

@chrisjsewell
Copy link
Contributor Author

For completeness, I also added comparison of application/json mimedata, using json.dumps

@vidartf vidartf self-assigned this Aug 9, 2019
@vidartf
Copy link
Collaborator

vidartf commented Sep 29, 2020

I included the first commit in #543. I'm not sure if the JSON one makes sense, as we already have structured JSON differ :) At the very least, I think we would need to use a sorted JSON serializer to have it be reliable.

What are the advantages to diffing JSON outputs as strings as you see it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants