Prevent listing/favourite icon jitter #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- attach the icon before the crumbs rather than within, so that it is never removed and just position it with CSS; this eliminates the need for mutation observer and throttling - improve performance of `hasFavorite` and `isVisible` checks by skipping sorting of items when querying for visible items - reduce CSS selector complexity for svg icons - remove unnecessary style rules - add class names needed for button hover - mnt: replace deprecated `toArray()` use with `Array.from`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #20
Code changes
<div>rather than within it, so that it is never removed; instead position it with CSS; this eliminates the need for mutation observer and throttlinghasFavoriteandisVisibleby skipping sorting of items when querying for visible itemstoArray()use withArray.fromUser-facing changes
There is no jitter when changing folders
The favourites icon stays in top right corner on resize
There is now a hover indicator