Disable favorite removal if path is unavailable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@fcollonval when you get a chance, can you review this? |
fcollonval
reviewed
Nov 25, 2021
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
|
@fcollonval No problem, line removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to create an issue, so I'll describe it here in the PR.
The current behavior of favorites is to remove a favorite link if the path can't be reached. I think this was meant to be a way to clean dead links, however, it has an unintended effect that if a given path is temporarily unavailable, clicking on the link will remove it.
This PR is simply to comment out the line responsible for removing the link automatically.