Add MariaDB to CI #10724
Merged
Add MariaDB to CI #10724
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
requested changes
Aug 16, 2024
|
I will also note that we do validate mariadb on the kine side: https://github.com/k3s-io/kine/blob/master/scripts/test-run-mysql#L28-L30 |
dereknola
requested changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10724 +/- ##
==========================================
- Coverage 49.82% 43.92% -5.90%
==========================================
Files 178 178
Lines 14801 14801
==========================================
- Hits 7374 6501 -873
- Misses 6083 7096 +1013
+ Partials 1344 1204 -140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Aug 26, 2024
Signed-off-by: robertsilen <robert.silen@iki.fi>
Co-authored-by: Derek Nola <derek.nola@suse.com> Signed-off-by: Robert Silén <robert.silen@iki.fi> Signed-off-by: robertsilen <robert.silen@iki.fi>
Co-authored-by: Derek Nola <derek.nola@suse.com> Signed-off-by: Robert Silén <robert.silen@iki.fi>
dereknola
approved these changes
Sep 18, 2024
brandond
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I suggest to add MariaDB to CI testing.
Types of Changes
Change to CI test.
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
I identified where the database type is checked, and added a section for mariadb, but honestly I don't know how to take it further from here. Can I get some tips on how to work on this?